ui: explain eslint plugin prequisite #83460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
A recent commit [1] introduced a custom eslint plugin that's hosted in this repo, but didn't add documentation around building that plugin to resolve errors reported in IDEs. Explain that eslint-plugin-crdb should be built to silence errors from eslint that get reported in editors. [1] ba68179 (ui: use esbuild-loader in webpack configs, 2022-05-26) Release note: None
sjbarag
force-pushed
the
explain-eslint-plugin-prereq
branch
from
8e2d477 to
ec32cbb
Compare
laurenbarker
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @sjbarag)
pkg/ui/README.md line 28 at r1 (raw file):
or by building the plugin manually: ```shell $ pushd pkg/ui/workspaces/eslint-plugin-crbd; yarn && yarn build; popd
Huh, TIL about pushd & popd
|
bors r=laurenbarker |
maryliag
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
thanks for this!
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit [1] introduced a custom eslint plugin that's hosted in
this repo, but didn't add documentation around building that plugin to
resolve errors reported in IDEs. Explain that eslint-plugin-crdb should
be built to silence errors from eslint that get reported in editors.
[1] ba68179 (ui: use esbuild-loader in webpack configs, 2022-05-26)
Release note: None