changefeedccl: block testfeed closure on canceled status #83226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Jun 22, 2022
TestChangefeedNemeses would sometimes flake on cloudstorage sink likely due to the feed writing files during the tempdirectory closing. Stress testing it on cloudstorage sink failed at 160 executions. This small change blocks feed.Close() on actually seeing the "cancelled" job status to ensure the feed is completely stopped prior to Close completing. Release note: None
samiskin
force-pushed
the
cdc-testfeed-close-wait
branch
from
fd3368e to
b91b729
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82794
TestChangefeedNemeses would sometimes flake on cloudstorage sink likely
due to the feed writing files during the tempdirectory closing. Stress
testing it on cloudstorage sink failed at 160 executions.
This small change blocks feed.Close() on actually seeing the "cancelled"
job status to ensure the feed is completely stopped prior to Close
completing. Running cloudstorage Nemeses did not fail after 500+ executions.
Release note: None