Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachprod: move prometheus package to cmd/roachprod #83148

Merged
merged 1 commit into from
Jun 22, 2022
Merged

roachprod: move prometheus package to cmd/roachprod #83148

merged 1 commit into from
Jun 22, 2022

Conversation

msbutler
Copy link
Collaborator

This simple refactor is prerequisite for adding roachprod commands that manage a
promethius/grafana instances.

Release note: None

@msbutler msbutler requested a review from tbg June 21, 2022 19:46
@msbutler msbutler requested a review from a team as a code owner June 21, 2022 19:46
@msbutler msbutler self-assigned this Jun 21, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler force-pushed the butler-move-grafana branch from f236520 to 704a259 Compare June 21, 2022 21:32
@msbutler msbutler requested a review from a team as a code owner June 21, 2022 21:32
@msbutler msbutler force-pushed the butler-move-grafana branch 2 times, most recently from 3591027 to e4adaeb Compare June 22, 2022 11:40
@msbutler
roachprod: move prometheus package to pkg/roachprod
03cb66a 
This simple refactor is prerequisite for adding roachprod  commands that
manage promethius/grafana instances on the VMs running roachprod.

Release note: None
@msbutler msbutler force-pushed the butler-move-grafana branch from e4adaeb to 03cb66a Compare June 22, 2022 15:40
@msbutler msbutler requested a review from irfansharif June 22, 2022 17:14
irfansharif
irfansharif approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/promethius/prometheus in the commit message + PR title. I assume in the subsequent PR we'll break the pkg/cmd/roachprod/prometheus -> pkg/cmd/roachtest/option dependency link?

@msbutler
Copy link
Collaborator Author

bors r=irfansharif

@msbutler msbutler changed the title roachprod: move promethius package to cmd/roachprod roachprod: move prometheus package to cmd/roachprod Jun 22, 2022
@msbutler
Copy link
Collaborator Author

I assume in the subsequent PR we'll break the pkg/cmd/roachprod/prometheus -> pkg/cmd/roachtest/option dependency link?
Correct

Come demo day, I hope to spell prometheus correctly on my first try :D

@craig
Copy link
Contributor

craig bot commented Jun 22, 2022

Build succeeded:

@craig craig bot merged commit 0050edb into cockroachdb:master Jun 22, 2022
@msbutler msbutler deleted the butler-move-grafana branch June 22, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

@tbg tbg Awaiting requested review from tbg

Assignees

@msbutler msbutler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbutler @cockroach-teamcity @irfansharif