Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: set no-remote-cache for GoPath, propagate tags #82843

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

rickystewart
Copy link
Collaborator

On my machine, building the GoPath takes a lot of time but it's almost
all in caching apparently. I turn off caching with the no-remote-cache
tag, but this has no effect unless we also set
--experimental_allow_tags_propagation. See the
issue upstream.
I suspect that --experimental_allow_tags_propagation will be useful in
other places as well for our fine-tuning.

Release note: None

@rickystewart rickystewart requested a review from rail June 13, 2022 19:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

On my machine, building the `GoPath` takes a lot of time but it's almost
all in caching apparently. I turn off caching with the `no-remote-cache`
tag, but this has no effect unless we also set
`--experimental_allow_tags_propagation`. See the
[issue upstream](bazelbuild/bazel#8830).
I suspect that `--experimental_allow_tags_propagation` will be useful in
other places as well for our fine-tuning.

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Jun 14, 2022

Build succeeded:

@craig craig bot merged commit b0c2f3a into cockroachdb:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants