Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to version 1.17.11 #82816

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Upgrade Go to version 1.17.11 #82816

merged 1 commit into from
Jun 13, 2022

Conversation

rail
Copy link
Member

@rail rail commented Jun 13, 2022

  • Adjust version in Docker image
  • Adjust version in the TeamCity agent image
  • Rebuild and push the Docker image
  • Download ALL the archives (.tar.gz, .zip) for the new Go version from https://golang.org/dl/ and mirror them in the public-bazel-artifacts bucket in the Bazel artifacts project in GCP (sub-directory go, next to the other Go SDK's).
  • Bump the version in WORKSPACE under go_download_sdk. You may need to bump rules_go. Also edit the filenames listed in sdks and update all the hashes to match what you mirrored in the step above.
  • Run ./dev generate bazel to refresh distdir_files.bzl, then bazel fetch @distdir//:archives to ensure you've updated all hashes to the correct value.
  • Bump the version in builder.sh accordingly
  • Bump the default installed version of Go in bootstrap-debian.sh
  • Update the builder.dockerImage parameter in the TeamCity Cockroach and Internal projects.
  • Deploy new TeamCity agent images

Partially addresses #82808

Release note: None

@rail rail requested a review from a team as a code owner June 13, 2022 12:48
@rail rail self-assigned this Jun 13, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail requested a review from rickystewart June 13, 2022 13:43
@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Jun 13, 2022
Copy link
Collaborator

@jlinder jlinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rail
Copy link
Member Author

rail commented Jun 13, 2022

TFTR!

@rail
Copy link
Member Author

rail commented Jun 13, 2022

bors r=jlinder

Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing to update.

pkg/cmd/roachtest/tests/go_helpers.go Show resolved Hide resolved
@rail
Copy link
Member Author

rail commented Jun 13, 2022

bors cancel

@craig
Copy link
Contributor

craig bot commented Jun 13, 2022

Canceled.

* [x] Adjust version in Docker image
* [x] Adjust version in the TeamCity agent image
* [x] Rebuild and push the Docker image
* [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go
  version from https://golang.org/dl/ and mirror them in the
  `public-bazel-artifacts` bucket in the `Bazel artifacts` project in
  GCP (sub-directory `go`, next to the other Go SDK's).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may
  need to bump
  [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit
  the filenames listed in `sdks` and update all the hashes to match what
  you mirrored in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then
  `bazel fetch @distdir//:archives` to ensure you've updated all hashes
  to the correct value.
* [x] Bump the version in `builder.sh` accordingly
* [x] Bump the default installed version of Go in `bootstrap-debian.sh`
* [ ] Update the `builder.dockerImage` parameter in the TeamCity
  [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams)
  and
  [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams)
  projects.
* [ ] Deploy new TeamCity agent images

Partially addresses cockroachdb#82808

Release note: None
@rail
Copy link
Member Author

rail commented Jun 13, 2022

bors r=jlinder,rickystewart

@craig
Copy link
Contributor

craig bot commented Jun 13, 2022

Build succeeded:

@craig craig bot merged commit 0e5927a into cockroachdb:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants