Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: clean up BatchRequest.IsLeaseRequest #82798

Merged

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Jun 12, 2022

Commit pulled from #82758.

This commit cleans up BatchRequest.IsLeaseRequest by replacing its internals with a call to isSingleRequestWithMethod(RequestLease) and renaming it to mirror the rest of the BatchRequest.IsSingleXYZRequest methods.

This commit cleans up `BatchRequest.IsLeaseRequest` by replacing its
internals with a call to `isSingleRequestWithMethod(RequestLease)` and
renaming it to mirror the rest of the `BatchRequest.IsSingleXYZRequest`
methods.
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner June 12, 2022 15:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 21, 2022

Build succeeded:

@craig craig bot merged commit 4ee236c into cockroachdb:master Jun 21, 2022
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/singleLeaseReq branch June 21, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants