Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump Pebble to a015e5a0cd29 #82736

Closed

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Jun 10, 2022

a015e5a0 db: exclude empty batch range deletion, range key iterators
8b7a68b8 compaction: introduce multi level compaction mechanics
67f2653a *: pass keyspan.Spans by pointer not value
83b45b0a internal/keyspan: refactor InterleavingIter bounds checking
c3053e0b internal/keyspan: manually inline {start,end}Bound in MergingIter
728722c5 internal/keyspan: refactor DefragmentingIter's invalid span checks
a5d4e00e db: add BenchmarkIteratorSeekNoRangeKeys
96dc71db internal/keyspan: preallocate merging iter levels, items
86dd6fd5 internal/keyspan: replace calls to Span.Visible

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens requested a review from a team June 10, 2022 16:43
```
a015e5a0 db: exclude empty batch range deletion, range key iterators
8b7a68b8 compaction: introduce multi level compaction mechanics
67f2653a *: pass keyspan.Spans by pointer not value
83b45b0a internal/keyspan: refactor InterleavingIter bounds checking
c3053e0b internal/keyspan: manually inline {start,end}Bound in MergingIter
728722c5 internal/keyspan: refactor DefragmentingIter's invalid span checks
a5d4e00e db: add BenchmarkIteratorSeekNoRangeKeys
96dc71db internal/keyspan: preallocate merging iter levels, items
86dd6fd5 internal/keyspan: replace calls to Span.Visible
```

Release note: None
@jbowens jbowens force-pushed the jackson/pebble-master-a015e5a0cd29 branch from 5d467f5 to 038cddf Compare June 10, 2022 16:52
@jbowens jbowens requested a review from a team as a code owner June 10, 2022 16:52
Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)

@jbowens
Copy link
Collaborator Author

jbowens commented Jun 10, 2022

Oof looks like cockroachdb/pebble#1749 introduced a bug—going to dig in this afternoon.

@jbowens jbowens closed this Jun 10, 2022
@jbowens jbowens deleted the jackson/pebble-master-a015e5a0cd29 branch June 10, 2022 17:50
@jbowens jbowens restored the jackson/pebble-master-a015e5a0cd29 branch June 10, 2022 18:10
@jbowens jbowens deleted the jackson/pebble-master-a015e5a0cd29 branch June 10, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants