bazel: unlist unsupported os+arch combos #82635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
requested changes
Jun 8, 2022
irfansharif
force-pushed
the
220608.unsupported-os-arch
branch
from
7f3cafa to
c93319e
Compare
irfansharif
commented
Jun 8, 2022
There was a problem hiding this comment.
Done.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @sjbarag)
rickystewart
approved these changes
Jun 8, 2022
|
Looks fine, you just have to resolve the conflicts. |
We don't support these for CRDB builds. Even windows is experimental, but lets keep that around anyway since we publish binaries for it. Release note: None
irfansharif
force-pushed
the
220608.unsupported-os-arch
branch
from
c93319e to
7dfd132
Compare
|
Thanks! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support these for CRDB builds. Even windows is experimental,
but lets keep that around anyway since we publish binaries for it.
+cc #82625.
Release note: None