Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix SPLIT AT and EXPERIMENTAL_RELOCATE for multi-column geo-spatial indexes #82632

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Jun 8, 2022

sql: add index hints for inverted_filter_geospatial_dist

This commit adds index hints to queries in
invert_filter_geospatial_dist logic tests. This ensures that the tests
are testing inverted filterer logic, which is their intent.

Release note: None

sql: fix SPLIT AT and EXPERIMENTAL_RELOCATE for multi-column geo-spatial indexes

This commit fixes a bug that prevented ALTER INDEX ... SPLIT AT and
ALTER TABLE ... EXPERIMENTAL_RELOCATE from working on multi-column
geo-spatial indexes.

Release note: None

mgartner added 2 commits June 8, 2022 17:06
This commit adds index hints to queries in
`invert_filter_geospatial_dist` logic tests. This ensures that the tests
are testing inverted filterer logic, which is their intent.

Release note: None
…ial indexes

This commit fixes a bug that prevented `ALTER INDEX ... SPLIT AT` and
`ALTER TABLE ... EXPERIMENTAL_RELOCATE` from working on multi-column
geo-spatial indexes.

Release note: None
@mgartner mgartner requested review from michae2 and sumeerbhola June 8, 2022 21:09
@mgartner mgartner requested a review from a team as a code owner June 8, 2022 21:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice, I was wondering about that [0].

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

@mgartner
Copy link
Collaborator Author

mgartner commented Jun 9, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 9, 2022

Build succeeded:

@craig craig bot merged commit b6f42c2 into cockroachdb:master Jun 9, 2022
@mgartner mgartner deleted the fix-split-at branch June 9, 2022 17:43
@mgartner mgartner restored the fix-split-at branch December 22, 2022 16:14
@mgartner mgartner deleted the fix-split-at branch December 22, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants