-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql,tree,eval: update oid functions to use uint32 #82568
Conversation
Postgres always uses 32 bits, so we shouldn't use a 64 bit type to represent this. Release note: None
Make it take a uint32 (OID) instead of a DInt. Release note: None
Use a uint32 instead of a DInt, so we don't accidentally perform any precision-losing type conversions. Release note: None
This is safer than allowing in a caller to pass in any DInt. Release note: None
Release note: None
Release note: None
973974d
to
c48196c
Compare
tftr! bors r=otan |
This PR was included in a batch that was canceled, it will be automatically retried |
Build succeeded: |
c48196c is responsible for a regression on a micro-benchmark:
Is this concerning? |
Hm, I reverted c48196c, and it didn't seem to make a difference, at least on master branch. I'll leave it to you Rafi in case you do wanna look closer into this - it's possible that we have fixed a regression that was exposed by this PR in some other way. |
Thanks for the investigation! I will explore it a bit later, but probably won't probe too much deeper |
fixes #41904
See individual commits.