release-22.1: server, ui: handle null plan gist in getStatementDetailsPerPlanHash #82557
+18
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #82436 on behalf of @ericharmeling.
/cc @cockroachdb/release
This PR adds a new function that handles null plan gists in
getStatementDetailsPerPlanHash
. The PR also adds some logic to hide null plan gists in the SqlBox of the Statement Details page.Here's a screenshot of the Statement Details page when the plan gist is null:
Fixes #82095.
We probably want to figure out why there are null values in
planner.instrumentation.planGist
in the first place.getStatementDetailsPerPlanHash
is pulling from the system table populated with the plan gist fromplanner.instrumentation.planGist
. CC @cucaroachRelease note: None
Release justification: bug fix