sql: fix CREATE TABLE LIKE with implicit pk

[jasonmchan]

Previously, CREATE TABLE LIKE copied implicitly created columns (e.g.
for the rowid default primary key and hash sharded index). Defaults for
some of these columns were not properly copied over in some cases,
causing unexpected constraint violations to surface.

This commit fixes this by skipping copying such columns; instead, they
will be freshly created. Followup work is needed for REGIONAL BY ROW.

Fixes #82401

Release note: None

[cockroach-teamcity]

This change is 

[chengxiong-ruan]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

[knz]

That solution is not sufficient. See my additional comment in #82401.

[chengxiong-ruan]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @ajwerner and @jasonmchan)

---

pkg/sql/create_table.go line 2894 at r2 (raw file):

		return false, err
	}
	if td.IsShardColumn(col) {

Could you also add logic tests where the source table has hash sharded index and expression index?

[chengxiong-ruan]

pkg/sql/create_table.go line 2894 at r2 (raw file):

Previously, chengxiong-ruan (Chengxiong Ruan) wrote…

Could you also add logic tests where the source table has hash sharded index and expression index?

oops, there is already test coverage for hash sharded index.

[jasonmchan]

I'm going to omit a fix for REGIONAL BY ROW because #82672 causes problems with this solution. Will put up a new revision for the broken CI tests.

[chengxiong-ruan]

I'd suggest adding a test case for expression index like `INDEX idx_expr (a + 2)` which would create a hidden virtual column which can be seen by selecting from the `crdb_internal.table_columns` table. I think this is working with PR but up to you to add it or not :)

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @jasonmchan)

[jasonmchan]

TFTR! I'm leaving out the expression index test for now because this PR doesn't change how they are handled.

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)