sql: fix assignment of global typDelim var #82526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that caused tests to fail under stress. Release note: None
|
This change is |
andreimatei
reviewed
Jun 7, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @otan and @rafiss)
pkg/sql/pg_catalog.go line 2803 at r1 (raw file):
_ = typCategoryBitString commaTypDelim = tree.NewDString(",")
can this be const?
|
unfortunately no, since bors p=1000 r=andreimatei |
|
bors p=10000 |
|
lol one more try bors merge p=10000 |
ecwall
approved these changes
Jun 7, 2022
|
Build succeeded: |
otan
reviewed
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #82304
This fixes a bug that caused tests to fail under stress.
Release note: None