kvserver/rangefeed: move CatchUpScan() params to constructor
#82452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
rangefeed-catchup-params
branch
from
d1b6388 to
040068b
Compare
stevendanna
approved these changes
Jun 6, 2022
miretskiy
approved these changes
Jun 6, 2022
erikgrinaker
force-pushed
the
rangefeed-catchup-params
branch
from
040068b to
03c63d5
Compare
`CatchUpIterator` took keyspan and start time parameters both in the constructor and when calling `CatchUpScan()`. This wasn't safe, because the iterator could have been constructed with bounds that would not satisfy the parameters passed to the scan -- for example, if passing a wider key span or lower start time -- in which case the scan would omit values. This patch removes the keyspan and start time parameters to `CatchUpScan()`, such that the caller must provide them during construction Release note: None
erikgrinaker
force-pushed
the
rangefeed-catchup-params
branch
from
03c63d5 to
590da0d
Compare
|
TFTRs! bors r=stevendanna,miretskiy |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CatchUpIteratortook keyspan and start time parameters both in theconstructor and when calling
CatchUpScan(). This wasn't safe, becausethe iterator could have been constructed with bounds that would not
satisfy the parameters passed to the scan -- for example, if passing a
wider key span or lower start time -- in which case the scan would omit
values.
This patch removes the keyspan and start time parameters to
CatchUpScan(), such that the caller must provide them duringconstruction
Release note: None