ppc64le - fix geogfn and geomfn test failures #82250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
blathers-crl
bot
added
O-community
|
This change is |
|
@rafiss, please review. |
|
looks like there are some build failures - namely you need to run |
geogfn
- TestAzimuth/north_east
- TestSegmentize/LINESTRING(1.0_1.0,_2.0_2.0,_3.0_3.0),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0),_(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1)),_maximum_segment_length:_50000.000000
- TestSegmentize/MULTILINESTRING((1.0_1.0,_2.0_2.0,_3.0_3.0),_(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTILINESTRING_(EMPTY,_(1.0_1.0,_2.0_2.0,_3.0_3.0),_(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTIPOLYGON(((3.0_3.0,_4.0_3.0,_4.0_4.0,_3.0_3.0)),_((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0),_(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1))),_maximum_segment_length:_100000.000000
- TestSegmentize/GEOMETRYCOLLECTION_(POINT_(40_10),LINESTRING_(10_10,_20_20,_10_40),POLYGON_((40_40,_20_45,_45_30,_40_40))),_maximum_segment_length:_1000000.000000
- TestSegmentize/LINESTRING(0_0_25,_0_1_0,_2_5_100),_maximum_segment_length:_150000.000000
- TestSegmentizeCoords/Coordinate(85,_85)_to_Coordinate(0,_0),_0.29502092024628396
- TestSegmentizeCoords/Coordinate(0,_16,_23,_10)_to_Coordinate(1,_0,_-5,_0),_0.07848050723825097
- TestProject/SRID
geomfn - TestGenerateRandomPoints/Polygon_with_a_hole
Cherry picks cockroachdb#66621
Release note: None
Co-authored-by: Oliver Tan <[email protected]>
prashantkhoje
force-pushed
the
ppc64le-geo-fp-fixes
branch
from
7ac79fb to
02c0eac
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geogfn
- TestAzimuth/north_east
- TestSegmentize/LINESTRING(1.0_1.0,_2.0_2.0,_3.0_3.0),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,0.0_0.0),(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1)),_maximum_segment_length:_50000.000000
- TestSegmentize/MULTILINESTRING((1.0_1.0,_2.0_2.0,3.0_3.0),(6.0_6.0,_7.0_6.0)),maximum_segment_length:100000.000000
- TestSegmentize/MULTILINESTRING(EMPTY,(1.0_1.0,_2.0_2.0,3.0_3.0),(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTIPOLYGON(((3.0_3.0,_4.0_3.0,_4.0_4.0,3.0_3.0)),((0.0_0.0,_1.0_0.0,_1.0_1.0,0.0_0.0),(0.1_0.1,_0.2_0.1,_0.2_0.2,0.1_0.1))),maximum_segment_length:100000.000000
- TestSegmentize/GEOMETRYCOLLECTION(POINT(40_10),LINESTRING(10_10,_20_20,10_40),POLYGON((40_40,_20_45,_45_30,_40_40))),_maximum_segment_length:_1000000.000000
- TestSegmentize/LINESTRING(0_0_25,_0_1_0,_2_5_100),_maximum_segment_length:_150000.000000
- TestSegmentizeCoords/Coordinate(85,_85)_to_Coordinate(0,_0),_0.29502092024628396
- TestSegmentizeCoords/Coordinate(0,_16,_23,_10)_to_Coordinate(1,0,-5,_0),_0.07848050723825097
- TestProject/SRID
geomfn - TestGenerateRandomPoints/Polygon_with_a_hole
Cherry picks #66621
Release note: None
Co-authored-by: Oliver Tan [email protected]