-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachprod: support --secure flag for start-tenant #82248
Conversation
3bc52a7
to
a17f0d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @otan and @stevendanna)
pkg/roachprod/install/cluster_synced.go
line 1124 at r2 (raw file):
mkdir -p tenant-certs/certs cp certs/ca.crt tenant-certs/certs/ cp certs/client.* tenant-certs/certs/
This will not work as expected with the new incoming code around tenant scoped certificates i.e. after this PR - #79065 merges.
Instead of copying the client certificates as is, you will need to recreate these certificates by adding a tenant scope with the specific tenant IDs. The CLI changes to add tenant scopes have already been merged so you should be able to update your PR to add a tenant scope along the lines of what is already being done for roachtests:
if v.AtLeast(version.MustParse("v22.2.0")) { |
f50a04a
to
64c31fb
Compare
The in-development tenant streaming features require a secure tenant to test them properly. This change adds support for the --secure flag when starting a tenant. When passed, we use the host cluster to generate tenant-client certificates and distribute them to the tenant cluster, along with the CA and previously created client certificates. For simplicity, we've stuck with using a single CA for all certificate creation. Release note: None
64c31fb
to
31ccbc5
Compare
@rimadeodhar Thanks, updated with the version check. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but also let's get a look from test-eng.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @srosenberg and @stevendanna)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @srosenberg)
bors r+ |
Build succeeded: |
The in-development tenant streaming features require a secure tenant
to test them properly.
This change adds support for the --secure flag when starting a
tenant. When passed, we use the host cluster to generate tenant-client
certificates and distribute them to the tenant cluster, along with the
CA and previously created client certificates.
For simplicity, we've stuck with using a single CA for all certificate
creation.
Release note: None