release-22.1: demo: fix enterprise features for multitenancy + remove license API call #82080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lti-region` When using `--geo-partitioned-replicas`, some secondary regions are added, which is only supported with multitenancy if a cluster setting is also set. So this commit ensures the cluster setting is set. NB: no unit tests in this commit because the next commit will ensure this gets tested. Release note: None
|
This change is |
knz
changed the title
otan
approved these changes
May 30, 2022
This patch achieves two things: - it ensures that enterprise features work properly in multi-tenant `cockroach demo` when `--disable-demo-license` is not passed as argument. - it ensures `cockroach demo` does not require a working licensing endpoint to run (by not retrieving a license over the network on startup). The net result will be less spurious failures in CI, as well as avoiding startup delays/errors during interactive uses, which provide poor UX. Release note: None
knz
force-pushed
the
backport22.1-81762-81737
branch
from
780e371 to
bde7e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
cockroach demo movr --geo-partitioned-replicas --multi-region" (democluster: fixcockroach demo movr --geo-partitioned-replicas --multi-region#81762)Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: bug fix and improvement to rate of CI false negatives