rpc: split URL generation code to a separate lightweight package (cli refactor sequence 2/n) #82069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20220528-certs1
branch
2 times, most recently
from
0d9a1e0 to
1732699
Compare
knz
force-pushed
the
20220528-certs2
branch
2 times, most recently
from
f09168d to
e96011d
Compare
otan
approved these changes
May 30, 2022
|
(NB: Holding off on merging this despite the review approval, since we can't merge intermediate PRs in a sequence without dropping the entire sequence off github.) |
knz
force-pushed
the
20220528-certs2
branch
2 times, most recently
from
edf0866 to
d434e26
Compare
This is needed to move the LoadSecurityOptions code to a lightweight package independent of 'security'. Release note: None
Release note: None
This paves the way to moving them to a standalone package. Release note: None
This paves the way further to move them to a separate package. Release note: None
This allows clarifies their scope as separate from the RPC logic. Release note: None
We have enough things called "PGURL" as it is. This rename clarifies the purpose. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR split from #82020 to ease review.