kvserver: skip TestCheckConsistencyInconsistent under race
#82042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The test is rather slow and also timing-dependent, which can result in false positives. Furthermore, the call to `TestingSetRedactable` triggers the race detector. This patch therefore disables the test under the race detector. Release note: None
erikgrinaker
force-pushed
the
skip-consistency-test-under-race
branch
from
a650e21 to
9d4794f
Compare
tbg
approved these changes
May 31, 2022
|
bors r=tbg |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is rather slow and also timing-dependent, which can result in
false positives. Furthermore, the call to
TestingSetRedactabletriggers the race detector. This patch therefore disables the test under
the race detector.
Touches #81819.
Release note: None