roachprod: avoid invoking cockroach version
#81912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
approved these changes
May 26, 2022
It seems this was only being used to for compatibility with v20.2 that expected different logging arguments. That version is no longer officially supported, and in CI/elsewhere, we build roachprod using the SHA from the specific release. Avoiding the version here lets me use roachprod with crdb binaries that don't stamp in the version: cockroachdb#79360. Avoiding stamping can shave off a few precious seconds in builds. Release note: None
irfansharif
force-pushed
the
220526.roachprod-crdbversion
branch
from
793d398 to
72ba744
Compare
srosenberg
approved these changes
May 26, 2022
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only being used for compatibility with v20.2 nodes
expecting different logging arguments. That version is no longer
officially supported, and in CI/elsewhere, we build roachprod using the
SHA from the specific release. Avoiding the version here lets me use
roachprod with crdb binaries that don't stamp in the version:
#79360 (avoiding stamping
can shave off a few precious seconds in builds).
Release note: None