Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: don't use the streamer for queries with mutations #81838

Merged
merged 1 commit into from
May 25, 2022

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented May 25, 2022

Backport 1/1 commits from #81796.

/cc @cockroachdb/release


Previously, we could try to use the streamer for the queries with
mutations. The streamer requires the usage of the LeafTxn whereas
mutations expect the usage of the RootTxn. The streamer's requirement
would win, and mutations were more likely to encounter retryable errors
that are propagated back to the client.

This was an oversight, and the mutations' requirement should win. This
commit makes it so that we don't use the streamer API if we don't know
for sure that there are no mutations in the plan. We could be smarter
and allow the usage of the streamer for some queries with mutations
(when we can prove that there is no concurrency between the root and the
leaf txns), but that doesn't seem important at the moment and is left as
a TODO.

Fixes: #80823.

Release note: None

Release justification: low risk bug fix.

Previously, we could try to use the streamer for the queries with
mutations. The streamer requires the usage of the LeafTxn whereas
mutations expect the usage of the RootTxn. The streamer's requirement
would win, and mutations were more likely to encounter retryable errors
that are propagated back to the client.

This was an oversight, and the mutations' requirement should win. This
commit makes it so that we don't use the streamer API if we don't know
for sure that there are no mutations in the plan. We could be smarter
and allow the usage of the streamer for some queries with mutations
(when we can prove that there is no concurrency between the root and the
leaf txns), but that doesn't seem important at the moment and is left as
a TODO.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented May 25, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich marked this pull request as ready for review May 25, 2022 16:23
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)

@yuzefovich yuzefovich merged commit e4ca082 into cockroachdb:release-22.1 May 25, 2022
@yuzefovich yuzefovich deleted the backport22.1-81796 branch May 25, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants