sql: enforce NOT NULL when adding a virtual computed column #81693
Conversation
|
This change is |
complete! 1 of 0 LGTMs obtained
Before this change, we did not ever validate that newly added virtual computed columns which were marked NOT NULL actually were not NULL. This is because there historically, in the legacy schema changer, we'd validate the `NULL` nature of the column when performing a column backfill. In the declarative schema changer, we don't do a column backfill, so we have bugs aplenty related to the general failure to check the `NULL` disposition of the data (see cockroachdb#81679). This change only affects the legacy schema changer so that it can be backported. A separate issue (cockroachdb#81690) has been filed for parity in the declarative schema changer. Release note (bug fix): Before this change, not validation was performed when adding a virtual computed column which was marked `NOT NULL`. This meant that it was possible to have a virtual computed column with an active `NOT NULL` constraint despite having rows in the table for which the column was `NULL`. This has now been fixed.
ajwerner
force-pushed
the
ajwerner/enforce-nullability-for-newly-added-virtual-columns-legacy
branch
from
ae220c1 to
84bb802
Compare
|
TFTR! bors r=chengxiong-ruan |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 84bb802 to blathers/backport-release-21.2-81693: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. error creating merge commit from 84bb802 to blathers/backport-release-22.1-81693: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
Does this need a backport still? |
Before this change, we did not ever validate that newly added
virtual computed columns which were marked NOT NULL actually were
not NULL. This is because there historically, in the legacy schema changer,
we'd validate the
NULLnature of the column when performing a columnbackfill. In the declarative schema changer, we don't do a column backfill,
so we have bugs aplenty related to the general failure to check the
NULLdisposition of the data (see #81679).
This change only affects the legacy schema changer so that it can be
backported. A separate issue (#81690) has been filed for parity in the
declarative schema changer.
Release note (bug fix): Before this change, not validation was performed
when adding a virtual computed column which was marked
NOT NULL. This meantthat it was possible to have a virtual computed column with an active
NOT NULLconstraint despite having rows in the table for which the column was
NULL.This has now been fixed.