storage: respect new Pebble iterator visibility #81662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
mvcc-iterator-visibility
branch
from
c06a99d to
4c35637
Compare
Pebble recently tightened its iterator semantics such that it has a static view of the underlying reader as of the time of its creation. Previously, a batch iterator could see batch writes that occurred after the iterator was created. This patch prepares CRDB for this change. Release note: None
erikgrinaker
force-pushed
the
mvcc-iterator-visibility
branch
from
4c35637 to
804d06c
Compare
|
Not seeing any further test failures in CI when running this with Pebble at cockroachdb/pebble@3355a02e7cec. I had a closer look at this by dumping a stack trace in I think this is about as good as we can do for now. We can try to catch any issues here via improved MVCC metamorphic tests or |
jbowens
approved these changes
May 24, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
|
bors r=jbowens |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pebble recently tightened its iterator semantics such that it has a
static view of the underlying reader as of the time of its creation.
Previously, a batch iterator could see batch writes that occurred after
the iterator was created.
This patch prepares CRDB for this change.
Touches cockroachdb/pebble#1640.
Release note: None