sql,stmtdiagnostics: remove some version gates #81558
Conversation
This commit addresses several TODOs with my name on them about removing the version gates, mostly around the conditional statement diagnostics introduced in 22.1 cycle. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @yuzefovich)
pkg/sql/row/kv_batch_streamer.go line 30 at r1 (raw file):
// useStreamerEnabled determines whether the Streamer API should be used. // TODO(yuzefovich): remove this in 23.1.
Was this bumped because the streamer is incomplete?
There was a problem hiding this comment.
Reviewable status:
pkg/sql/row/kv_batch_streamer.go line 30 at r1 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
Was this bumped because the streamer is incomplete?
Yeah, I think for sure we want to keep the setting for 22.2 release and then re-evaluate whether it is safe to have the streamer on by default without an escape hatch for 23.1 (maybe we'll remote the setting in 23.2, we'll see).
|
TFTR! bors r+ |
|
Build succeeded: |
This commit addresses several TODOs with my name on them about removing
the version gates, mostly around the conditional statement diagnostics
introduced in 22.1 cycle.
Release note: None