lint: enable the CODEOWNERS linter on non-clean workdirs #81467
Conversation
Prior to this patch, the linter would bark if there were spurious files in otherwise-empty unowned directories (e.g. pkg/). This patch fixes it. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist and @knz)
pkg/internal/codeowners/lint.go line 69 at r1 (raw file):
"README.md": {}, } skipGlobs := []string{
Seems odd that these globs are not part of .gitignore; if they were, we could load them from there to avoid bit rot.
There was a problem hiding this comment.
Thanks stan!
bors r=srosenberg
Reviewable status:
pkg/internal/codeowners/lint.go line 69 at r1 (raw file):
Previously, srosenberg (Stan Rosenberg) wrote…
Seems odd that these globs are not part of .gitignore; if they were, we could load them from there to avoid bit rot.
- IIRC they are not because folk have argued in the past that "this type of global ignores belongs to a ~/.gitignore file, not a per-project one".
- the .gitignore files are strewn across multiple levels of the hierarchy. The cost of loading them, and then applying the rules in the right order and the right way (NB, gitignore has its own matching syntax and order, not simple globs), seems more hassle than is worth here.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
|
Build succeeded: |
Prior to this patch, the linter would bark if there were spurious
files in otherwise-empty unowned directories (e.g. pkg/).
This patch fixes it.
Release note: None