Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1.0: acceptance: update how we build the python compose image #81391

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 17, 2022

Backport 1/1 commits from #81313 on behalf of @rickystewart.

/cc @cockroachdb/release


Up until this point we were using apt install postgresql-client to
install the psql binary in this image. Because the postgresql-client
apt package was apparently updated to a later version of postgres
last week that includes this change,
the TestComposeGSSPython acceptance test started failing with the
following error:

psql: error: private key file "/certs/client.root.key" must be owned by the current user or root

Less recent versions of psql are more permissive about cert
permissions, so we work around this by simply copying a less recent
version of psql from the older postgres:11 image.

Release note: None
Release justification: Test-only change


Release justification:

@blathers-crl blathers-crl bot requested a review from a team May 17, 2022 18:13
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1.0-81313 branch from 5692487 to 1511f03 Compare May 17, 2022 18:13
@blathers-crl
Copy link
Author

blathers-crl bot commented May 17, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from otan May 17, 2022 18:13
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 17, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Up until this point we were using `apt install postgresql-client` to
install the `psql` binary in this image. Because the `postgresql-client`
`apt` package was apparently updated to a later version of `postgres`
last week that includes [this change](https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a59c79564bdc209a5bc7b02d706f0d7352eb82fa),
the `TestComposeGSSPython` `acceptance` test started failing with the
following error:

```
psql: error: private key file "/certs/client.root.key" must be owned by the current user or root
```

Less recent versions of `psql` are more permissive about cert
permissions, so we work around this by manually installing postgres 11.

Release note: None
Release justification: Test-only change
@rickystewart rickystewart force-pushed the blathers/backport-release-22.1.0-81313 branch from 1511f03 to 75dcce2 Compare May 17, 2022 19:55
@rickystewart
Copy link
Collaborator

Looks like we're not merging to release-22.1.0 any longer, so this PR can be closed.

@mgartner mgartner deleted the blathers/backport-release-22.1.0-81313 branch May 23, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants