asim: fix uniqueness invariant on adding ranges #81144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
lidorcarmel
approved these changes
May 16, 2022
There was a problem hiding this comment.
thanks!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @kvoli)
Previously adding a new range would be not hold the invariant that minKey [minKey,endKey) must be unique. This patch updates the assertion and adds testing for this invariant. Release note: None
kvoli
force-pushed
the
220509.asim-range-eq
branch
from
cf46f1d to
8b7d65b
Compare
kvoli
commented
May 17, 2022
There was a problem hiding this comment.
TYFTR!
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously adding a new range would be not hold the invariant that
minKey [minKey,endKey) must be unique. This patch updates the assertion
and adds testing for this invariant.
Release note: None