Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: sql: add sql.txn.contended.count metrics #81070

Merged
merged 2 commits into from
May 6, 2022
Merged

release-22.1: sql: add sql.txn.contended.count metrics #81070

merged 2 commits into from
May 6, 2022

Conversation

Azhng
Copy link
Contributor

@Azhng Azhng commented May 5, 2022

Depends on the previous backport #81068

Expose transaction contention metric for #73566.

Release note (sql change): new sql.txn.contended.count metric
exposes total number of transactions that experienced contentions.

Release justification: low risk high benefit change to existing functionality

Azhng added 2 commits March 31, 2022 22:01
@Azhng
sql: collect contention stats for sql stats when tracing is enabled
b3e2b68 
Resolves cockroachdb#78675

Previously, contention stats was not collected for SQL Stats even when
tracing was enabled. This was caused by two bugs:
1. instrumentationHelper skipping analyzing traces when tracing is enabled
2. transaction statistics ignore traces when tracing is turned on at the
higher level.

This commit ensures that contention stats is collected when tracing is
turned on.

Release note (bug fix): Contention statistics are now being collected for
SQL Stats when tracing is enabled.
@Azhng
sql: add sql.txn.contended.count metrics
75b9033 
Expose transaction contention metric for cockroachdb#73566.

Release note (sql change): new sql.txn.contended.count metric
exposes total number of transactions that experienced contentions.
@Azhng Azhng requested review from a team May 5, 2022 20:45
@Azhng Azhng requested a review from a team as a code owner May 5, 2022 20:45
@blathers-crl
Copy link

blathers-crl bot commented May 5, 2022 •
edited by Azhng
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

maryliag
maryliag approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: once tests are passing and dependent PR is merged

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@Azhng Azhng merged commit d82c6e6 into cockroachdb:release-22.1 May 6, 2022
@cockroach-teamcity cockroach-teamcity mentioned this pull request May 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azhng @cockroach-teamcity @maryliag