Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-{provisional,}-artifacts: create arm64 builds for non-release #81060

Merged
merged 1 commit into from
May 5, 2022

Conversation

rickystewart
Copy link
Collaborator

These new binaries will only be built for the non-release case.

Release note: None

These new binaries will only be built for the non-release case.

Release note: None
@rickystewart rickystewart requested a review from rail May 5, 2022 17:19
@rickystewart rickystewart requested a review from a team as a code owner May 5, 2022 17:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail
Copy link
Member

rail commented May 5, 2022

I wonder if we should split the build builder configuration into two. The first one will be our supported platform and the second one for "not yet supported" platforms. This way we don't block the supported platforms pipeline if something happens to the other platform builds. What do you think?

@rickystewart
Copy link
Collaborator Author

Your call, I am not really enough of an expert to speak to whether that's an advantage.

One thing I will say is that we do build the arm64 version of cockroach in CI so it is pretty unlikely (though still possible) for that build to break but not the others.

@rickystewart
Copy link
Collaborator Author

YOLO

bors r=rail

@craig
Copy link
Contributor

craig bot commented May 5, 2022

Build succeeded:

@craig craig bot merged commit da04bc2 into cockroachdb:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants