-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asim: replica load adapter #81004
asim: replica load adapter #81004
Conversation
facb285
to
47d5752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, minor nits.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @kvoli)
-- commits
line 11 at r1:
typo?
Code quote:
aggregaton
pkg/kv/kvserver/asim/load.go
line 21 at r1 (raw file):
// order to record and report load events. type ReplicaLoad interface { // AppluLoad applies a load event to a replica.
typo
Code quote:
AppluLoad
pkg/kv/kvserver/asim/load.go
line 65 at r1 (raw file):
// replica within the store. func (s *Store) Capacity() roachpb.StoreCapacity { capacity := roachpb.StoreCapacity{}
just to make sure I understand correctly - we will need to populate more fields for capacity here, right? such as roachpb.StoreCapacity.capacity
and available
etc.
worth adding a todo?
This patch introduces an adapter for the simulator state of load on stores and replicas, into the datastructures supported by the allocator. Replica load may be experimented with in the future and this patch defines an interface for interacting with recording and summarizing replica load. Store load is partially an aggregation of replica load and therefore relies on the replica load interface to calculate capacity. Release note: None
47d5752
to
6152275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYFTR!
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lidorcarmel)
Previously, lidorcarmel (Lidor Carmel) wrote…
typo?
Updated.
pkg/kv/kvserver/asim/load.go
line 21 at r1 (raw file):
Previously, lidorcarmel (Lidor Carmel) wrote…
typo
Updated.
pkg/kv/kvserver/asim/load.go
line 65 at r1 (raw file):
Previously, lidorcarmel (Lidor Carmel) wrote…
just to make sure I understand correctly - we will need to populate more fields for capacity here, right? such as
roachpb.StoreCapacity.capacity
andavailable
etc.
worth adding a todo?
Added.
bors r+ |
Build succeeded: |
This patch introduces an adapter for the simulator state of load on
stores and replicas, into the datastructures supported by the allocator.
Replica load may be experimented with in the future and this patch
defines an interface for interacting with recording and summarizing
replica load.
Store load is partially an aggregaton of replica load and
therefore relies on the replica load interface to calculate capacity.
Release note: None