-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest/django: miscellaneous changes #80841
Conversation
I'm not sure if there's a reason why the repo needs to be cloned in the first place. I would advocate to replace the clone and install with There are a couple of other obsolete things in this file that I noticed, namely |
does i can remove the extraneous flags though. |
The test suite is in the Django repo, not in django-cockroachdb. |
Release note: None
doesn't seem to work:
|
Sorry, that should be: |
Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+ |
Build succeeded: |
We do this for /mnt/data1/django, so do django-cockroach too, just in
case. Not sure if it'll do anything, but just in case.
Refs: #80614
Release note: None