Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest/django: miscellaneous changes #80841

Merged
merged 2 commits into from
May 2, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented May 1, 2022

We do this for /mnt/data1/django, so do django-cockroach too, just in
case. Not sure if it'll do anything, but just in case.

Refs: #80614

Release note: None

@otan otan requested a review from ZhouXing19 May 1, 2022 23:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@timgraham
Copy link
Contributor

I'm not sure if there's a reason why the repo needs to be cloned in the first place. I would advocate to replace the clone and install with pip install django-cockroachdb 4.0.x to always get the latest version from PyPI.

There are a couple of other obsolete things in this file that I noticed, namely RUNNING_COCKROACH_BACKEND_TESTS=1 and --parallel 1 are no longer needed.

@otan
Copy link
Contributor Author

otan commented May 2, 2022

does pip install django-cockroachdb 4.0.x also bring the tests in?

i can remove the extraneous flags though.

@timgraham
Copy link
Contributor

The test suite is in the Django repo, not in django-cockroachdb.

@otan otan changed the title roachtest/django: also remove django-cockroach beforehand roachtest/django: miscellaneous changes May 2, 2022
@otan
Copy link
Contributor Author

otan commented May 2, 2022

pip install django-cockroachdb 4.0.x

doesn't seem to work:

		Wraps: (5) pip3 install django-cockroachdb 4.0.x returned
		  | stderr:
		  | ERROR: Could not find a version that satisfies the requirement 4.0.x (from versions: none)
		  | ERROR: No matching distribution found for 4.0.x
		  |
		  | stdout:
		  | Defaulting to user installation because normal site-packages is not writeable
		  | Collecting django-cockroachdb
		  |   Using cached django_cockroachdb-4.0.1-py3-none-any.whl (25 kB)

@timgraham
Copy link
Contributor

Sorry, that should be: pip install django-cockroachdb==4.0.*

@otan otan force-pushed the django_delete branch from df9c5c0 to d43074a Compare May 2, 2022 11:09
Copy link
Collaborator

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@otan
Copy link
Contributor Author

otan commented May 2, 2022

bors r+

@craig craig bot merged commit 480c3e4 into cockroachdb:master May 2, 2022
@craig
Copy link
Contributor

craig bot commented May 2, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants