Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batcheval: handle MVCC range tombstones in ClearRange #80840

Merged
merged 1 commit into from
Jul 1, 2022
Merged

batcheval: handle MVCC range tombstones in ClearRange #80840

merged 1 commit into from
Jul 1, 2022

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented May 1, 2022 •
edited
Loading

This patch makes ClearRange account for MVCC range tombstones when
updating MVCC stats.

Touches #70412.

Release note: None

@erikgrinaker erikgrinaker requested a review from a team as a code owner May 1, 2022 19:14
@erikgrinaker erikgrinaker self-assigned this May 1, 2022
@erikgrinaker erikgrinaker requested a review from a team as a code owner May 1, 2022 19:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch 3 times, most recently from ab7e633 to 7f87857 Compare May 2, 2022 01:05
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones branch from cb77b2e to 49aacac Compare May 9, 2022 08:36
@erikgrinaker erikgrinaker requested a review from a team as a May 9, 2022 08:36
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch from 7f87857 to fe38145 Compare May 9, 2022 08:49
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones branch from 49aacac to e5bd560 Compare May 9, 2022 09:20
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch 2 times, most recently from 6607ed7 to 81fc002 Compare May 10, 2022 17:50
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch from 81fc002 to 4178adb Compare May 23, 2022 10:23
@erikgrinaker erikgrinaker marked this pull request as draft May 28, 2022 16:53
@erikgrinaker erikgrinaker changed the base branch from mvcc-range-tombstones to master May 30, 2022 12:32
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch from 4178adb to 4b33df2 Compare May 30, 2022 13:03
@erikgrinaker erikgrinaker removed the request for review from a team May 30, 2022 13:04
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch from 4b33df2 to 50aac2d Compare June 4, 2022 18:22
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch from 50aac2d to ac6424f Compare June 28, 2022 10:37
@erikgrinaker erikgrinaker marked this pull request as ready for review June 28, 2022 10:37
@erikgrinaker
Copy link
Contributor Author

This one's ready for final review @aliher1911.

@erikgrinaker
batcheval: handle MVCC range tombstones in ClearRange
5ca916d 
This patch makes `ClearRange` account for MVCC range tombstones when
updating MVCC stats.

Release note: None
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-clearrange branch from ac6424f to 5ca916d Compare June 30, 2022 09:39
aliher1911
aliher1911 reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR not rebased so that ExperimentalPutMVCCRangeKey is still uses range key without value? I think it looks ok, but RangeValCount and RangeValBytes are missing.

@erikgrinaker
Copy link
Contributor Author

Is this PR not rebased so that ExperimentalPutMVCCRangeKey is still uses range key without value? I think it looks ok, but RangeValCount and RangeValBytes are missing.

No, I think it accounts for them:

https://github.com/cockroachdb/cockroach/pull/80840/files#diff-1309daa5cc5ef9852a048ac405ae7d48d57d98be4362b745cfdea242699559b1R229-R230

Reviewing an old clone again?

aliher1911
aliher1911 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@aliher1911 aliher1911 left a comment •
edited by petermattis
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@erikgrinaker
Copy link
Contributor Author

TFTR!

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented Jul 1, 2022

Build succeeded:

@craig craig bot merged commit 39e9437 into cockroachdb:master Jul 1, 2022
@erikgrinaker erikgrinaker deleted the mvcc-range-tombstones-clearrange branch July 4, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliher1911 aliher1911 aliher1911 approved these changes

Assignees

@erikgrinaker erikgrinaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikgrinaker @cockroach-teamcity @aliher1911