-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: docker: fix docker image to suit storage in memory #80355
Merged
ZhouXing19
merged 2 commits into
release-22.1
from
blathers/backport-release-22.1-80036
Apr 22, 2022
Merged
release-22.1: docker: fix docker image to suit storage in memory #80355
ZhouXing19
merged 2 commits into
release-22.1
from
blathers/backport-release-22.1-80036
Apr 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the datasets created in the init process are stored on disk, and they are inaccessible if the “real” server is started with storage in memory. This is because for the container initialization, the current logic is: 1. start_init_server: start the single-node server in the background, with default on-disk storage setting; 2. run_init_queries: create default db and user, and run the init scripts saved in docker-entrypoint-initdb.d; 3. *stop the init server and restart the server* with given parameters in foreground. In this commit we start and keep running the init server with the given parameters, and eliminate the “stop and restart” step. Also, bring the server process from background to foreground with fg once all init queries are finished. Fixes #80005. Release note (docker): refactor the initialization process of the docker image to accomodate the use case with memory storage.
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.1-80036
branch
from
April 22, 2022 05:42
ae761e4
to
7b2bce8
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 22, 2022
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
otan
approved these changes
Apr 22, 2022
(Subscribing so I get a notification when this goes out - hopefully) |
@ZhouXing19 @rafiss should we merge this to v22.1.0? |
I'm in favor of adding it to 22.1.0. let me see what's needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #80036 on behalf of @ZhouXing19.
/cc @cockroachdb/release
Currently the datasets created in the init process are stored on disk,
and they are inaccessible if the “real” server is started with storage in memory.
This is because, for the container initialization, the current logic is:
default on-disk storage setting;
saved in
docker-entrypoint-initdb.d;
In this commit we start and keep running the init server with the given
parameters, and eliminate the “stop and restart” step. Also, bring the server
process from background to foreground with
fg
once all init queries are finished.Fixes #80005.
Release note (docker): refactor the initialization process of the docker image
to accomodate initialization scripts with memory storage.
Release justification: (Bug fixes and low-risk updates to new functionality) fix the docker image for the memory storage use case