bazel,dev: provide opt-out for building w/ nogo
#80317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Now we provide `--//build/toolchains:nogo_disable` as an option which will force `nogo` checks OFF even if you have globally configured `lintonbuild`. This can be used by end users for builds but primarily I want a way to force builds to finish faster when `nogo` checks are not particularly useful: namely, when building `dev` for the first time (via the `dev` script) and when building the `bazel-remote` binary. Also have `dev build` infer when passing `nogo_disable` will be OK and pass it in when appropriate. Release note: None
rickystewart
force-pushed
the
nogodisable
branch
from
34233f6 to
7f1e0c8
Compare
rail
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
|
TFTR :) bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we provide
--//build/toolchains:nogo_disableas an option whichwill force
nogochecks OFF even if you have globally configuredlintonbuild. This can be used by end users for builds but primarily Iwant a way to force builds to finish faster when
nogochecks are notparticularly useful: namely, when building
devfor the first time (viathe
devscript) and when building thebazel-remotebinary. Also havedev buildinfer when passingnogo_disablewill be OK and pass it inwhen appropriate.
Release note: None