Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/schemachanger: add a type for RuleName #80272

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

ajwerner
Copy link
Contributor

This lets it avoid getting redacted.

Release note: None

@ajwerner ajwerner requested a review from a team April 20, 2022 21:27
@ajwerner ajwerner requested a review from a team as a code owner April 20, 2022 21:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I'm actually curious when does redactions happen? I've seen something like this and I've heard people talking about it, but I don't when a string should be redacted and what's the consequences of being redacted...:

var redactionJSONBMarker = func() jsonb.JSON {

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@postamar
Copy link
Contributor

Some customers have their logs redacted due to security policies, and the redaction is opt-in by default so it can make the log output challenging to read sometimes. Also, sentry reports will always have redacted logs, see for example #80176

This lets it avoid getting redacted.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/rulename branch from d5160d1 to c3b08e5 Compare April 21, 2022 18:46
@ajwerner
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 24, 2022

Build succeeded:

@craig craig bot merged commit a3c0709 into cockroachdb:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants