bazel: run returncheck lint in nogo
#80263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
cc @jordanlewis |
rickystewart
force-pushed
the
returncheck
branch
3 times, most recently
from
a37bd01 to
8ba8a63
Compare
Unfortunately `returncheck` is not implemented as an `Analyzer` so it can't be integrated with `nogo` directly. Instead I've copied/adapted the existing code from https://github.com/cockroachdb/returncheck. The vendored `returncheck` can be deleted from tree when we no longer need to support `make lint`. Closes cockroachdb#73391. Release note: None
rickystewart
force-pushed
the
returncheck
branch
from
8ba8a63 to
64cb8f2
Compare
rail
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mari-crl)
|
TFTR! bors r=rail |
|
Build succeeded: |
|
blathers backport 22.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
returncheckis not implemented as anAnalyzerso itcan't be integrated with
nogodirectly. Instead I've copied/adaptedthe existing code from https://github.com/cockroachdb/returncheck. The
vendored
returncheckcan be deleted from tree when we no longer needto support
make lint.Closes #73391.
Release note: None