Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sqlsmith: skip crdb_internal.reset_multi_region_zone_configs_for_database" #80159

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

rytaft
Copy link
Collaborator

@rytaft rytaft commented Apr 19, 2022

This reverts commit c1a959a.
That commit was unnecessary because
crdb_internal.reset_multi_region_zone_configs_for_database already
existed in the list of functions to skip.

Release note: None

…for_database"

This reverts commit c1a959a.
That commit was unnecessary because
crdb_internal.reset_multi_region_zone_configs_for_database already
existed in the list of functions to skip.

Release note: None
@rytaft rytaft requested a review from yuzefovich April 19, 2022 12:28
@rytaft rytaft requested a review from a team as a code owner April 19, 2022 12:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rytaft
Copy link
Collaborator Author

rytaft commented Apr 19, 2022

pkg/internal/sqlsmith/schema.go, line 501 at r1 (raw file):

			"crdb_internal.unsafe_",
			"crdb_internal.create_join_token",
			"crdb_internal.reset_multi_region_zone_configs_for_database",

It's already here!

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed :) :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

Copy link
Collaborator Author

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

@craig
Copy link
Contributor

craig bot commented Apr 19, 2022

Build succeeded:

@craig craig bot merged commit 996f52c into cockroachdb:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants