-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: clisqlshell: implement COPY ... FROM STDIN
for CLI
#79819
release-22.1: clisqlshell: implement COPY ... FROM STDIN
for CLI
#79819
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
i'm not keen on backporting a dependency on a forked lib/pq if we can merge the change upstream |
latest lib pq changes introduced something somewhat unstable due to the cancel changes (when I updated last year a bunch of tests failed) so I'd rather use the fork. but maybe I'm misremembering.. I feel the smaller set of changes is safer as a backport so I'd rather do this for now. |
eh ill give it a shot, but if there are unrelated failing tests ill revert |
f0f5769
to
067def6
Compare
Steps: * Add a lower level API to lib/pq for use. * Add some abstraction boundary breakers in `clisqlclient` that allow a lower level handling of the COPY protocol. * Altered the state machine in `clisqlshell` to account for copy. Release note (cli change): COPY ... FROM STDIN now works from the cockroach CLI. It is not supported inside transactions.
067def6
to
30795c2
Compare
Backport 1/1 commits from #79629.
/cc @cockroachdb/release
Release justification: critical improvement to 22.1
Resolves #16392
Steps:
clisqlclient
that allow alower level handling of the COPY protocol.
clisqlshell
to account for copy.Release note (cli change): COPY ... FROM STDIN now works from the
cockroach CLI. It is not supported inside transactions.