Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: clisqlshell: implement COPY ... FROM STDIN for CLI #79819

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Apr 12, 2022

Backport 1/1 commits from #79629.

/cc @cockroachdb/release

Release justification: critical improvement to 22.1


Resolves #16392

Steps:

  • Add a lower level API to lib/pq for use.
  • Add some abstraction boundary breakers in clisqlclient that allow a
    lower level handling of the COPY protocol.
  • Altered the state machine in clisqlshell to account for copy.

Release note (cli change): COPY ... FROM STDIN now works from the
cockroach CLI. It is not supported inside transactions.

@otan otan requested a review from rafiss April 12, 2022 03:26
@otan otan requested a review from a team as a code owner April 12, 2022 03:26
@blathers-crl
Copy link

blathers-crl bot commented Apr 12, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Apr 12, 2022

i'm not keen on backporting a dependency on a forked lib/pq if we can merge the change upstream

@otan
Copy link
Contributor Author

otan commented Apr 12, 2022

latest lib pq changes introduced something somewhat unstable due to the cancel changes (when I updated last year a bunch of tests failed) so I'd rather use the fork. but maybe I'm misremembering.. I feel the smaller set of changes is safer as a backport so I'd rather do this for now.

@otan
Copy link
Contributor Author

otan commented Apr 12, 2022

eh ill give it a shot, but if there are unrelated failing tests ill revert

@otan otan force-pushed the backport22.1-79629 branch from f0f5769 to 067def6 Compare April 12, 2022 20:26
Steps:
* Add a lower level API to lib/pq for use.
* Add some abstraction boundary breakers in `clisqlclient` that allow a
  lower level handling of the COPY protocol.
* Altered the state machine in `clisqlshell` to account for copy.

Release note (cli change): COPY ... FROM STDIN now works from the
cockroach CLI. It is not supported inside transactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants