release-22.1: protectedts: fix panic when fetching protectedts records #79812
+77
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #79787 on behalf of @adityamaru.
/cc @cockroachdb/release
Previously, we incorrectly assumed that all records in the
system.protectedts_records
table would have a non NULL targetcolumn. While this is enforced for all protected timestamp
records written in a 22.1+ cluster, this is not true for records
that might have been prior to the 22.1 cluster version being
finalized.
This change makes the method responsible for reading protectedts
records more defensive when encountering a NULL target column.
Fixes: #79684
Release note: None
Release justification: high impact bug fix to existing functionality, prevents panic.