changefeedccl: Make scan request size configurable. #79690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @miretskiy)
pkg/ccl/changefeedccl/changefeedbase/settings.go, line 111 at r1 (raw file):
) var ScanRequestSize = settings.RegisterIntSetting(
nit: comment this for the linter
Add a `changefeed.backfill.scan_request_size` setting to control scan request size during backfill. The default is maintained at 16MB. However, some latency sensitive environments may choose to lower this setting, while increasing scan parallelism to ensure that the latches are held for shorter periods of time. Release Notes: Add a `changefeed.backfill.scan_request_size` setting to control scan request size during backfill. Relese Justification: Low danger stability and performance improvement.
|
bors r+ |
|
Build succeeded: |
This was referenced Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
changefeed.backfill.scan_request_sizesetting to controlscan request size during backfill. The default is maintained
at 16MB. However, some latency sensitive environments may choose
to lower this setting, while increasing scan parallelism to
ensure that the latches are held for shorter periods of time.
Release Notes: Add a
changefeed.backfill.scan_request_sizesettingto control scan request size during backfill.
Relese Justification: Low danger stability and performance improvement.