sql: version gating pkey virtual column validation.

[fqazi]

Fixes: #79329

Previously, the schemachange workload on master was failing
because 21.2 does not support virtual columns inside primary
keys. So, the mixed version variant of the schemachange workload
can fail when a primary key with virtual columns exists, specifically
these tables become inaccessible from 21.2 nodes. To address, this
patch introduces a version gate to prevent creating prevent
creating primary indexes with virtual columns and updates the
schemachange workload to detect when this error will be generated
in mixed version workloads.

Release note: None

[cockroach-teamcity]

This change is 

[fqazi]

Porting this over to master, since we need the same fix to avoid issues for now. At some point the version bump will happen and we can rip this code out

[postamar]

LGTM assuming this is the same as #79609

[chengxiong-ruan]

pkg/workload/schemachange/operation_generator.go, line 1138 at r1 (raw file):

				}
			} else if indexDef, ok := def.(*tree.IndexTableDef); ok {
				for _, indexCol := range indexDef.Columns {

sorry...my nasal congestion probably makes me not thinking clearly. But should we make this check more precise that check column is virtual instead of checking computed since computed column can be stored. Also should we check the index is primary?

[chengxiong-ruan]

Thanks for picking this up :)

[fqazi]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan)

---

pkg/workload/schemachange/operation_generator.go, line 1138 at r1 (raw file):

Previously, chengxiong-ruan (Chengxiong Ruan) wrote…

sorry...my nasal congestion probably makes me not thinking clearly. But should we make this check more precise that check column is virtual instead of checking computed since computed column can be stored. Also should we check the index is primary?

Yes your right, this should be checking for virtual not computed

[chengxiong-ruan]

😴 🛌

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan)

[fqazi]

@chengxiong-ruan @postamar TFTR!

[fqazi]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)