logictest: deflake tests with async statements #79628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While async statements in logictests were introduced in cockroachdb#79010, in some cases tests with async statements would fail due to a race condition. This is fixed by updating the logic such that when an async statement is issued, the goroutine running that statement is ensured to have started before execution continues to other lines in the test. Fixes cockroachdb#79565. Release note: None
|
This change is |
yuzefovich
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @AlexTalks)
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ea00dcc to blathers/backport-release-22.1-79628: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While async statements in logictests were introduced in #79010, in some
cases tests with async statements would fail due to a race condition.
This is fixed by updating the logic such that when an async statement is
issued, the goroutine running that statement is ensured to have started
before execution continues to other lines in the test.
Fixes #79565.
Release note: None
Release Justification: Testing change only.