Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/schemachanger/scrun: add validation in makeState #79590

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Apr 7, 2022

This addresses a TODO and has a test.

Release note: None

@ajwerner ajwerner requested a review from a team April 7, 2022 16:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is nice.

@ajwerner ajwerner force-pushed the ajwerner/address-todo branch 2 times, most recently from 7ef0602 to 1b02621 Compare April 8, 2022 14:00
@ajwerner
Copy link
Contributor Author

ajwerner commented Apr 8, 2022

@postamar this uncovered a testing issue. I also refactored a bit. Can you PTAL?

@postamar
Copy link
Contributor

postamar commented Apr 8, 2022

Interesting! LGTM

edit: it seems you need to --rewrite a few other data-driven tests.

This addresses a TODO and has a test. It also fixes a bug in the testing
infrastructure whereby we were using the wrong protocol buffer message
type to deserialize session data.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/address-todo branch from 1b02621 to d7fb91f Compare April 8, 2022 14:38
@ajwerner
Copy link
Contributor Author

ajwerner commented Apr 8, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 8, 2022

Build succeeded:

@craig craig bot merged commit d53a4c0 into cockroachdb:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants