ci: fix some janky ci scripts that prevent posting issues to github #79532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a couple places in `82e0b121c715c59cebbb8d53e29edf7952d6913f` I accidentally did `$exit_status=$?` instead of `exit_status=$?`, which is not a proper variable assignment. This was causing these jobs to fail before they could post issues to GitHub. Closes cockroachdb#79403. Release note: None
|
This change is |
mari-crl
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
give me please
stamp
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
|
Thanks a lot Ricky!! |
|
bors r=mari-crl |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple places in
82e0b121c715c59cebbb8d53e29edf7952d6913fIaccidentally did
$exit_status=$?instead ofexit_status=$?, which isnot a proper variable assignment. This was causing these jobs to fail
before they could post issues to GitHub.
Closes #79403.
Release note: None