Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: remove raft leader progress override in newTruncateDecision #79522

Merged
merged 1 commit into from
Apr 7, 2022
Merged

kv: remove raft leader progress override in newTruncateDecision #79522

merged 1 commit into from
Apr 7, 2022

Conversation

nvanbenschoten
Copy link
Member

Addresses a long-standing TODO.

We picked up etcd-io/etcd#10279 a while ago.

@nvanbenschoten
kv: remove raft leader progress override in newTruncateDecision
cacac45 
Addresses a long-standing TODO.

We picked up etcd-io/etcd#10279 a while ago.
@nvanbenschoten nvanbenschoten requested a review from tbg April 6, 2022 17:46
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner April 6, 2022 17:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member

tbg commented Apr 6, 2022

🤞🏽

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 7, 2022

Build succeeded:

@craig craig bot merged commit 38a3442 into cockroachdb:master Apr 7, 2022
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/pickUpReplicate branch April 9, 2022 17:45
@tbg tbg mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @cockroach-teamcity @tbg