release-21.1: opt: do not generate unnecessary cross-joins on join input

[mgartner]

Backport 1/2 commits from #79389.

/cc @cockroachdb/release

---

opt: do not generate unnecessary cross-joins on lookup join input

This commit fixes a bug that caused unnecessary cross-joins on the input
of lookup joins, causing both suboptimal query plans and incorrect query
results. The bug only affected lookup joins with lookup expressions.

Fixes #79384

Release note (bug fix): A bug has been fixed that caused the optimizer
to generate query plans with logically incorrect lookup joins. The bug
can only occur in queries with an inner join, e.g., t1 JOIN t2, if all
of the following are true:

1. The join contains an equality condition between columns of both
   tables, e.g., t1.a = t2.a.
2. A query filter or CHECK constraint constrains a column to a set
   of specific values, e.g., t2.b IN (1, 2, 3). In the case of a
   CHECK constraint, the column must be NOT NULL.
3. A query filter or CHECK constraint constrains a column to a
   range, e.g., t2.c > 0. In the case of a CHECK constraint, the
   column must be NOT NULL.
4. An index contains a column from each of the criteria above, e.g.,
   INDEX t2(a, b, c).
   This bug has been present since version 21.2.0.

opt: do not cross-join input of inverted semi-join

In #78685, we prevented GenerateLookupJoins from incorrect creating a
cross-join on the input of a semi-join, addressing #78681. This commit
addresses the same issue with GenerateInvertedJoins, which we
originally forgot to fix.

Informs #78681

Release note (bug fix): A bug has been fixed which caused the optimizer
to generate invalid query plans which could result in incorrect query
results. The bug, which has been present since version 21.1.0, can
appear if all of the following conditions are true:

1. The query contains a semi-join, such as queries in the form
   SELECT * FROM a WHERE EXISTS (SELECT * FROM b WHERE a.a @> b.b).
2. The inner table has a multi-column inverted index containing the
   inverted column in the filter.
3. The index prefix columns are constrained to a set of values via the
   filter or a CHECK constraint, e.g., with an IN operator. In the
   case of a CHECK constraint, the column is NOT NULL.

---

Release justification: Fixes a correctness bug in the optimizer.

[blathers-crl]

Thanks for opening a backport.

Please check the backport criteria before merging:

• Patches should only be created for serious issues or test-only changes.
• Patches should not break backwards-compatibility.
• Patches should change as little code as possible.
• Patches should not change on-disk formats or node communication protocols.
• Patches should not add new functionality.
• Patches must not add, edit, or otherwise modify cluster versions; or add version gates.

If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.

• There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
• The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
• New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
• The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

• What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
• Will this work in a cluster of mixed patch versions? Did we test that?
• If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

[cockroach-teamcity]

This change is 

[rytaft]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)