changefeedccl: error on duplicate targets #79465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonoreDB
requested review from
msbutler and
miretskiy
and removed request for
a team
|
This change is |
miretskiy
approved these changes
Apr 5, 2022
Previously, behavior if you gave two equivalent targets in a changefeed was undefined. This PR adds validation and an error. For example, `use defaultdb; CREATE CHANGEFEED FOR defaultdb.foo, TABLE foo` will error and give the canonicalized targets that resolved to the same table. You can still do `FOR db1.foo, db2.foo` as those will resolve to different tables even though they may emit to the same topic. Release note (sql change): Changefeed statements now detect duplicate targets and throw an error.
|
bors r=[miretskiy, shermanCRL] |
|
bors r- (Failing linters) |
|
Canceled. |
HonoreDB
force-pushed
the
error_on_duplicate_targets
branch
from
f5096a9 to
2111741
Compare
|
Sorry, forgot to push the style fix. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, behavior if you gave two equivalent targets in a changefeed
was undefined. This PR adds validation and an error.
For example,
use defaultdb; CREATE CHANGEFEED FOR defaultdb.foo, TABLE foowillerror and give the canonicalized targets that resolved to the same
table. You can still do
FOR db1.foo, db2.fooas those will resolveto different tables even though they may emit to the same topic.
Closes #78285
Release note (sql change): Changefeed statements now detect duplicate targets and throw an error.