Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: backupccl: mark backup ExportRequests as Bulk priority #79367

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

dt
Copy link
Member

@dt dt commented Apr 4, 2022

Backport 1/1 commits from #79086.

/cc @cockroachdb/release


This adds a new "bulk normal" priority that is lower than normal user priority but higher than low user priority, and then assigns that priority on AddSSTable and Export requests.

Release note (bug fix): BACKUP read requests are now sent with lower admission control priority than normal traffic.

Jira issue: CRDB-14711

Jira issue: CRDB-14758

@dt dt requested review from erikgrinaker and sumeerbhola April 4, 2022 19:31
@dt dt requested a review from a team as a code owner April 4, 2022 19:31
@dt dt requested review from a team and stevendanna and removed request for a team April 4, 2022 19:31
@blathers-crl
Copy link

blathers-crl bot commented Apr 4, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt merged commit ec91fe5 into cockroachdb:release-21.2 Apr 4, 2022
@dt dt deleted the backport21.2-79086 branch April 5, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants