dev: have doctor recommend running bazel clean --expunge once
#79334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is sometimes necessary to `bazel clean --expunge` once you've set up your machine, but we don't want to suggest this more than once. So we update the code to make sure that we only print that message if the doctor status file is newly created. Closes cockroachdb#74746. Release note: None
|
This change is |
mari-crl
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Looking good! :D
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rail)
|
bors r=mari-crl |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes necessary to
bazel clean --expungeonce you've set upyour machine, but we don't want to suggest this more than once. So we
update the code to make sure that we only print that message if the
doctor status file is newly created.
Closes #74746.
Release note: None
Jira issue: CRDB-14713