kvserver: log when acquiring lease as a draining node #79296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aayushshah15
force-pushed
the
20220403_logWhenStealingLeaseAsADrainingNode
branch
2 times, most recently
from
61fd234 to
690295e
Compare
shralex
approved these changes
Apr 4, 2022
nvanbenschoten
approved these changes
Apr 4, 2022
| ), | ||
| ) | ||
| } | ||
| log.VEventf( |
There was a problem hiding this comment.
This won't usually end up in the logs. Do we want to promote it to log.Info so that it will?
Generally, draining nodes are not allowed to acquire leases. Additionally, replicas that are not Raft leaders are not allowed to acquire leases. This means that draining nodes have to be permitted to acquire leases for replicas that they are the Raft leaders for. This commit adds a verbose log event when a draining store acquires a lease because it is the Raft leader. Release note: none
aayushshah15
force-pushed
the
20220403_logWhenStealingLeaseAsADrainingNode
branch
from
690295e to
5ffaa9e
Compare
|
TFTR bors r+ |
|
Build succeeded: |
|
blathers backport 21.2 22.1 |
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, draining nodes are not allowed to acquire leases. Additionally,
replicas that are not Raft leaders are not allowed to acquire leases. This
means that draining nodes have to be permitted to acquire leases for replicas
that they are the Raft leaders for (otherwise, we risk a deadlock since no
replicas will be allowed to acquire the lease).
This commit adds a verbose log event when a draining store acquires a lease
because it is the Raft leader.
Release note: none
Jira issue: CRDB-14751